Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

space key doesn't working well in Google Chrome via Japanese IME #242

Open
tomoyamachi opened this issue Apr 4, 2018 · 6 comments
Open

Comments

@tomoyamachi
Copy link

tomoyamachi commented Apr 4, 2018

Image:

image

enviroments:

  • Google Chrome ver 65.0.3325.181
  • Google 日本語入力(Japanese) ver 2.20.2700.1

Working well on other browsers(IE, FireFox...) and languages (Chinese ...) .

Steps to reproduce:

  1. Input two or more syllable words
  2. Press the space bar
@jfschwarz
Copy link
Contributor

This is probably the same problem as #234

@justincrich
Copy link

I'm having the same issue but with Korean, but only on IE Edge. If you make heads or tails on this let me know.

https://codesandbox.io/s/x2x62loryo

@timeshiftseiya
Copy link

When inputting Japanese continuously
https://github.com/signavio/react-mentions/blob/master/src/MentionsInput.js#L314

## before
let newValue = applyChangeToValue(
      value,
      markup,
      newPlainTextValue,
      this.state.selectionStart,
      this.state.selectionEnd,
      ev.target.selectionEnd,
      displayTransform,
      regex
    )
after
let newValue = newPlainTextValue === '@' ?
    applyChangeToValue(
      value,
      markup,
      newPlainTextValue,
      this.state.selectionStart,
      this.state.selectionEnd,
      ev.target.selectionEnd,
      displayTransform,
      regex
    ) : newPlainTextValue

Checking newPlainTextValue makes a good result

@wesleywong
Copy link

any idea can solve this issue in the latest version?

@mikellykels
Copy link

I wanted to raise that this problem still exists as a couple of our users have reported this issue. We're using version 4.3.0 - is there any update on if a fix is being worked on?

@mj-hd
Copy link

mj-hd commented Apr 14, 2022

I've confirmed that #499 fixes this problem.
I think the core problem is the cursor jumping by IME composition process.

First, the cursor is positioned after the sentence.(| shows the cursor position)

これはてすとです|

With pressing the space key to start composition process, the cursor moves to just after the first word to composite.

コレは|てすとです

This cursor jumping causes something wrong with the auto-correction handling logic, and duplicates the input text.

// some auto-correction is going on

Any plan to review & merge the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants