AUV error management #9

alessiaortile · 2023-08-31T09:10:02Z

No description provided.

campagn1

Great work! Some corrections need to be performed: I commented only one module, the suggestions apply to all.
Brava!

campagn1 · 2023-09-06T09:32:26Z

DESERT_Addons/uwauv/Makefile.am

+
+lib_LTLIBRARIES = libuwauv.la
+
+libuwauv_la_SOURCES = uwauv-module.cc uwauv-module.h uwauverror-module.cc  uwauverror-module.h uwauverror-b-module.cc  uwauverror-b-module.h uwauv-packet.h uwauvctr-module.cc uwauvctr-module.h uwauvctrer-module.cc uwauvctrer-module.h uwauvctrer-b-module.cc uwauvctrer-b-module.h  initlib.cc


this is fine, but in principle be aware that only the cc (or cpp) files need to be listed

campagn1 · 2023-09-06T09:37:14Z

DESERT_Addons/uwauv/uwauv-module.cc

+{
+	UWSMEPosition p = UWSMEPosition();
+	posit=&p;
+    bind("ackTimeout_", (int*) &ackTimeout);


(int*) or (double*)?

campagn1 · 2023-09-06T09:37:45Z

DESERT_Addons/uwauv/uwauv-module.cc

+	, out_file_stats(0)
+{
+	posit = p;
+    bind("ackTimeout_", (int*) &ackTimeout);


int or double?

campagn1 · 2023-09-06T09:39:58Z

DESERT_Addons/uwauv/uwauv-module.cc

+	else if(argc == 3){
+		if (strcasecmp(argv[1], "setPosition") == 0) {
+			UWSMEPosition* p = dynamic_cast<UWSMEPosition*> (tcl.lookup(argv[2]));
+			posit=p;


check if cast succeded with
if(p) {posit = p; ...}
if it did not, print that it failed and return TCL_ERR

campagn1 · 2023-09-06T09:41:05Z

DESERT_Addons/uwauv/uwauv-module.cc

+			if (atof(argv[2]) == 3) {
+				ackPolicy = ACK_PGBK_OR_TO;
+				return TCL_OK;
+			}


add else {cerr<< "Policy not supported" << std::endl; return TCL_ERR;}

campagn1 · 2023-09-06T10:27:17Z

DESERT_Framework/DESERT/mobility/uwsmeposition/uwsmeposition.h

+	**/
+	virtual int command(int argc, const char *const *argv);
+
+	virtual void setdest(


better doxygen (we will make it for smposition as well)

campagn1 · 2023-09-06T10:27:35Z

DESERT_Framework/DESERT/mobility/uwsmeposition/uwsmeposition.h

+	virtual void setdest(
+			double x_dest, double y_dest, double z_dest, double spead);
+
+	virtual void adddest(


campagn1 · 2023-09-06T10:28:08Z

DESERT_Framework/DESERT/mobility/uwsmeposition/uwsmeposition.h

+
+	virtual void adddest(double x_dest, double y_dest, double z_dest);
+
+	virtual void setAlarm(bool alarm);


alarm for what? Add doxygen

campagn1 · 2023-09-06T10:28:31Z

DESERT_Framework/DESERT/mobility/uwsmeposition/uwsmeposition.h

+protected:
+	/**
+	* Method that updates both the position coordinates
+	*/


doxygen @param now ..

campagn1 · 2023-09-06T10:29:17Z

DESERT_Framework/DESERT/mobility/uwsmeposition/uwsmeposition.h

+
+private:
+
+	std::vector<std::vector<double>> waypoints; 


doxygen with
variable; /**< description here */

campagn1

check the intentation as in the old comment

campagn1 · 2023-09-21T06:39:19Z

DESERT_Addons/uwauv/uwauv-module.h

+#define HDR_UWAUV_MONITORING(p) (hdr_uwAUV_monitoring::access(p))
+#define HDR_UWAUV_CTR(p) (hdr_uwAUV_ctr::access(p))
+
+using namespace std;


please, remove "using namespace std;"

fedefava86 · 2023-09-20T15:54:02Z

DESERT_Addons/uwauv/Makefile.am

@@ -0,0 +1,51 @@
+#
+# Copyright (c) 2007 Regents of the SIGNET lab, University of Padova.


We are trying to begin to be consistent on this, so i would put 2023 here. I know we never updated it, but we should start

DESERT_Addons/uwauv/m4/desert.m4

fedefava86 · 2023-09-20T16:06:14Z

DESERT_Addons/uwauv/uwauv-module.cc

+	, ackPriority(0)
+	, ackNotPgbk(0)
+	, drop_old_waypoints(0)
+	, log_flag(0)


I would call it sth more consisent, like "log_on_file", this way is more clear for what is this flag (we all know it's a flag)

fedefava86 · 2023-09-20T16:07:13Z

DESERT_Addons/uwauv/uwauv-module.cc

+				ackPolicy = ACK_PGBK_OR_TO;
+				return TCL_OK;
+			}else{
+				cerr<<"Plicy not supported" << std::endl;


Suggested change

cerr<<"Plicy not supported" << std::endl;

cerr<<"Policy not supported" << std::endl;

fedefava86 · 2023-09-20T16:13:56Z

DESERT_Addons/uwauv/uwauv-module.cc

+
+void UwAUVModule::recv(Packet* p) {
+
+	hdr_uwAUV_ctr* uwAUVh = hdr_uwAUV_ctr::access(p);


Are ALL the packets travelling in the network with this header for sure?

fedefava86 · 2023-09-21T14:41:47Z

DESERT_Framework/DESERT/samples/desert_samples/AUV/metric_comp_4.py

@@ -0,0 +1,188 @@
+import csv
+import matplotlib.pyplot as plt


this does not come with a standard python installation i guess. Did you installed a custom pip? if so, better write in a readme, so that someone else know in advance which deps he needs to be installed and how

fedefava86 · 2023-09-21T14:42:37Z

DESERT_Framework/DESERT/samples/desert_samples/AUV/plot_coordinates.py

@@ -0,0 +1,152 @@
+import csv
+import matplotlib.pyplot as plt
+import tikzplotlib


same as before

fedefava86 · 2023-09-21T14:42:55Z

DESERT_Framework/DESERT/samples/desert_samples/AUV/plot_error_evolution.py

@@ -0,0 +1,173 @@
+import csv
+import matplotlib.pyplot as plt


fedefava86 · 2023-09-21T14:43:14Z

DESERT_Framework/DESERT/samples/desert_samples/AUV/result_compute.py

@@ -0,0 +1,428 @@
+import matplotlib.pyplot as plt


fedefava86 · 2023-09-21T14:44:15Z

DESERT_Framework/DESERT/samples/desert_samples/dbs/wp_path/rov_path.csv

@@ -99,3 +99,66 @@
 2361.830056,-99.802673,-48.175367,-15.000000
 2391.136904,-99.950656,-24.868989,-15.000000
 2422.005942,-100.000000,-0.000000,-15.000000
+2622.000000,100.000000,0.000000,-15.000000


@campagn1 is this used in other simulations? is this ok with the other tcl or do we have to do some no-regression on other tcls?

alessiaortile and others added 22 commits May 29, 2023 16:58

AUV e SV module

84d8f29

AUV error application + simulation

385851f

add error tx period + plot trajectories

c4ab409

log-error sending-error reception correction

6e3dd90

branch correction

1a26c47

name correction + plot update

0677513

new mobility model with error management

d1cd7b4

correction alarm mode(static)

00bffb8

waypoints queue

9684565

added control validity pkt rcv

62a9441

waypoints

63aaee5

noisy error management

fd3ae9a

add basic version

be0f558

uwsme correction

9e7817e

simulation correction

38a9ecb

log msg fixed

e20ac56

simulation analysis

b7b1dc5

sim fixed

c50cc96

double tx correction

da3bed6

simulation parameters update

f76bca7

power computation

97c9eba

tp counter correction + last err correction

61cc8ad

campagn1 reviewed Sep 6, 2023

View reviewed changes

Alessia Ortile added 2 commits September 13, 2023 16:49

review correction p1

f4fc526

review correction p2

933885d

campagn1 reviewed Sep 21, 2023

View reviewed changes

fedefava86 requested changes Sep 21, 2023

View reviewed changes

fedefava86 marked this pull request as draft September 21, 2023 14:44

Alessia Ortile added 2 commits October 19, 2023 13:16

review correction p3

a027250

spaces to tab conversion

9c97862

Alessia Ortile added 10 commits October 23, 2023 21:51

added rov immersion to the simulation

3df744c

added rover immersion to the simulation

23623a4

postion log correction

c757443

range ctr correction

5ef0a6c

dyoxigen corrections

aaabfd8

indentation correction

91f02b2

blank to tab

8b8122e

blank to tab

645162b

blank to tab

ed5df9e

blanks to tab

a0cb4a4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AUV error management #9

AUV error management #9

alessiaortile commented Aug 31, 2023

campagn1 left a comment

campagn1 Sep 6, 2023

campagn1 Sep 6, 2023

campagn1 Sep 6, 2023

campagn1 Sep 6, 2023

campagn1 Sep 6, 2023

campagn1 Sep 6, 2023

campagn1 Sep 6, 2023

campagn1 Sep 6, 2023

campagn1 Sep 6, 2023

campagn1 Sep 6, 2023

campagn1 left a comment

campagn1 Sep 21, 2023

fedefava86 Sep 20, 2023

fedefava86 Sep 20, 2023

fedefava86 Sep 20, 2023

fedefava86 Sep 20, 2023

fedefava86 Sep 21, 2023

fedefava86 Sep 21, 2023

fedefava86 Sep 21, 2023

fedefava86 Sep 21, 2023

fedefava86 Sep 21, 2023


		lib_LTLIBRARIES = libuwauv.la

		libuwauv_la_SOURCES = uwauv-module.cc uwauv-module.h uwauverror-module.cc uwauverror-module.h uwauverror-b-module.cc uwauverror-b-module.h uwauv-packet.h uwauvctr-module.cc uwauvctr-module.h uwauvctrer-module.cc uwauvctrer-module.h uwauvctrer-b-module.cc uwauvctrer-b-module.h initlib.cc


		virtual void adddest(double x_dest, double y_dest, double z_dest);

		virtual void setAlarm(bool alarm);

		@@ -0,0 +1,51 @@
		#
		# Copyright (c) 2007 Regents of the SIGNET lab, University of Padova.

	cerr<<"Plicy not supported" << std::endl;
	cerr<<"Policy not supported" << std::endl;


		void UwAUVModule::recv(Packet* p) {

		hdr_uwAUV_ctr* uwAUVh = hdr_uwAUV_ctr::access(p);

AUV error management #9

Are you sure you want to change the base?

AUV error management #9

Conversation

alessiaortile commented Aug 31, 2023

campagn1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

campagn1 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment