You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In Rust 1.82 the compiler has gained the ability to recognise (and warn) for unreachable patterns due to uninhabited types like void::Void, ! and std::convert::Infallible.
In order to keep Lighthouse compiling on 1.82 beta and earlier versions, we've added #[allow(unreachable_patterns)] in a few places. Once the MSRV is 1.82 or greater we can remove these allows and the match arms that they apply to.
Present Behaviour
Describe the present behaviour of the application, with regards to this
issue.
Steps to resolve
Once Rust 1.82 is stable and we're OK with increasing the MSRV:
Increase the MSRV to 1.82
Remove all instances of void::unreachable and allow(unreachable_patterns) found using grep.
The text was updated successfully, but these errors were encountered:
Description
In Rust 1.82 the compiler has gained the ability to recognise (and warn) for unreachable patterns due to uninhabited types like
void::Void
,!
andstd::convert::Infallible
.In order to keep Lighthouse compiling on 1.82 beta and earlier versions, we've added
#[allow(unreachable_patterns)]
in a few places. Once the MSRV is 1.82 or greater we can remove theseallow
s and the match arms that they apply to.Present Behaviour
Describe the present behaviour of the application, with regards to this
issue.
Steps to resolve
Once Rust 1.82 is stable and we're OK with increasing the MSRV:
void::unreachable
andallow(unreachable_patterns)
found usinggrep
.The text was updated successfully, but these errors were encountered: