--disable-deposits flag of validator manager create command requires BLS withdrawal credentials with unclear failure message

[ralexstokes]

Description

Conflicting options with unclear docs on how to resolve.

Version

v5.3.0

Present Behaviour

This command fails:

lighthouse vm create --disable-deposits --count 1 --output-path $OUTPUT

with output

--eth1-withdrawal-address is required.

Upon closer inspection, it looks like the issue is that the tool is trying to make 0x01 withdrawal credentials. But even if you supply --eth1-withdrawal-address, we get a conflicting message about use of --disable-deposits.

Expected Behaviour

I should be able to use --disable-deposits.

Steps to resolve

The resolution is to use the --force-bls-withdrawal-credentials but this isn't clear from the docs and was only apparent after reading the source code. Could simply add some context to the help message for the --disable-deposits flag.

[chong-he]

Thanks for reporting!

Would it make this clear if we add a sentence in the description here:
If used, the --force-bls-withdrawal-credentials is also required to ensure users are aware that an --eth1-withdrawal-address is not set

lighthouse/validator_manager/src/create_validators.rs

Lines 117 to 129 in 2e0eb6d

	.arg(
	Arg::new(DISABLE_DEPOSITS_FLAG)
	.long(DISABLE_DEPOSITS_FLAG)
	.help(
	"When provided don't generate the deposits JSON file that is \
	commonly used for submitting validator deposits via a web UI. \
	Using this flag will save several seconds per validator if the \
	user has an alternate strategy for submitting deposits.",
	)
	.action(ArgAction::SetTrue)
	.help_heading(FLAG_HEADER)
	.display_order(0),
	)