Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move bundles to v0.2 #105

Open
loosebazooka opened this issue Oct 11, 2023 · 5 comments
Open

Move bundles to v0.2 #105

loosebazooka opened this issue Oct 11, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@loosebazooka
Copy link
Member

Just thinking about this problem since protobuf-specs says about v0.1 bundles: https://github.com/sigstore/protobuf-specs/blob/main/protos/sigstore_bundle.proto#L62

There aren't really too many compatibility issues but maybe v0.1 support should be optional for clients in conformance tests?
@loosebazooka loosebazooka added the enhancement New feature or request label Oct 11, 2023
@haydentherapper
Copy link
Collaborator

Agreed. We should have some tests for v1 for clients that care, but I don’t think we should mandate v1 support.

@woodruffw
Copy link
Member

Fully agreed as well!

@woodruffw
Copy link
Member

#109 starts on this as a bugfix, but others need to be moved as well.

@segiddins
Copy link
Member

I think we also need a v0.3 test as well

@woodruffw
Copy link
Member

I think we also need a v0.3 test as well

Yep. sigstore-python has begun verifying 0.3 bundles in our development series, and our 3.x release will default to 0.3 for both signing and verifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@loosebazooka @segiddins @woodruffw @haydentherapper