Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve selftest invocation #185

Open
jku opened this issue Jan 13, 2025 · 1 comment · May be fixed by #187
Open

improve selftest invocation #185

jku opened this issue Jan 13, 2025 · 1 comment · May be fixed by #187
Assignees
Labels
enhancement New feature or request

Comments

@jku
Copy link
Member

jku commented Jan 13, 2025

Invoking the test suite manually and in the CI selftest is a little clunky:

  • in the CI case workflow generates a shell script that calls the sigstore-python-conformance wrapper that calls "sigstore" binary
  • in the manual testing case, using Makefile sigstore-python currently gets installed in the same virtual environment as the test suite requirements: this might be something we don't want (imagine those two needing different protobuf-specs versions for a while).

A possible solution might be:

  • make Makefile setup a separate "sigstore-env" virtual environment, like CI workflow does
  • make sigstore-python-conformance expect the "sigstore-env" virtual environment (and use sigstore binary from $SCRIPTDIR/sigstore-env/bin/sigstore)

This should keep CLI testing about as easy as it is now and would make the workflow simpler since the generated script would not be needed

@jku jku added the enhancement New feature or request label Jan 13, 2025
@jku jku self-assigned this Jan 14, 2025
@jku
Copy link
Member Author

jku commented Jan 14, 2025

I'll try to do something about this: testing #182 is already painful without improvements

@jku jku linked a pull request Jan 14, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant