-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Policy for verifying with key #105
Comments
Having either For a specific verification, I would prefer That said, providing a matcher based on key hint (as @haydentherapper linked to) is a good utility option to provide, as it may be enough for certain scenarios. |
See my comment in sigstore/protobuf-specs#236 (comment) for more reasoning. |
…ey (#235) To address #105. Right now, if you have a bundle signed with a key, your verification policy needs to include WithoutIdentitiesUnsafe(). This isn't great though because: - bundles signed with keys aren't inherently unsafe - there isn't a way to require your bundle was signed with a key; a bundle signed with a certificate would pass WithoutIdentitiesUnsafe(). --------- Signed-off-by: Zach Steindler <[email protected]>
This was added in #235 |
Description
Currently, when verifying with a key, you must specify
WithoutIdentitiesUnsafe()
when creating the policy verifier because no identity is provided. It would be more accurate to have a method such asWithKeyHint
orWithKeyID
, since identities are not needed when verifying with a key. Either this method could take a key fingerprint, or it could take no fingerprint given the bundle should contain a key hint.If verifying with a Sigstore bundle, a key hint should be provided as a public key identifier. As long as the trust root contains the public key, we can match based on this key hint (currently implemented here. If this is not populated, either a) we should err out, or b) we should use a hint provided via the policy method.
Related: sigstore/protobuf-specs#236 to simplify providing trusted keys.
cc @kommendorkapten @codysoyland @rdimitrov
The text was updated successfully, but these errors were encountered: