Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support intermediate certificates in VerificationMaterial certificate chain #132

Open
steiza opened this issue Mar 28, 2024 · 0 comments · May be fixed by #253
Open

Support intermediate certificates in VerificationMaterial certificate chain #132

steiza opened this issue Mar 28, 2024 · 0 comments · May be fixed by #253
Assignees
@cmurphy
Labels
enhancement New feature or request

Comments

@steiza
Copy link
Member

steiza commented Mar 28, 2024

Description

Currently, in https://github.com/sigstore/sigstore-go/blob/main/pkg/bundle/bundle.go when we get a bundle that includes a certificate chain in the verification materials, we assume there is only 1 leaf certificate in the "chain" and no intermediates.

This needs to change if we're going to support certificate chains that include intermediates.

This came up in #101 (comment).
@steiza steiza added the enhancement New feature or request label Mar 28, 2024
@steiza steiza mentioned this issue Mar 28, 2024
Merged
@cmurphy cmurphy self-assigned this Jul 23, 2024
@cmurphy cmurphy linked a pull request Aug 1, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmurphy cmurphy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support intermediate certificates in bundle cmurphy/sigstore-go
2 participants
@steiza @cmurphy