From 13d2fa6161523f114675b46e25ab48a54423c179 Mon Sep 17 00:00:00 2001 From: Danny Rorabaugh Date: Fri, 18 Oct 2024 14:55:49 -0400 Subject: [PATCH] Revert aws-login change (part2) --- deploy/helm/aws-login/values.yaml | 2 +- docs/deploy/kubernetes_design/README.md | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/deploy/helm/aws-login/values.yaml b/deploy/helm/aws-login/values.yaml index ee5791a235..2d81c4601a 100644 --- a/deploy/helm/aws-login/values.yaml +++ b/deploy/helm/aws-login/values.yaml @@ -25,7 +25,7 @@ awsEcr: imageTag: "0.3.0" jobName: ecr-cred-helper schedule: "0 */8 * * *" - secretsName: aws-login-credentials + secretsName: aws-ecr-credentials serviceAccount: account-ecr-login role: role-ecr-login roleBinding: role-ecr-login-binding diff --git a/docs/deploy/kubernetes_design/README.md b/docs/deploy/kubernetes_design/README.md index a51a5de788..90f8cb36e0 100644 --- a/docs/deploy/kubernetes_design/README.md +++ b/docs/deploy/kubernetes_design/README.md @@ -134,10 +134,10 @@ The following diagram shows the Kubernetes resources used to create the image pu ### Additional AWS Login Resources -| Resource | Kind | Description | -| --------------------- | --------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -| aws-ecr-config | ConfigMap | `aws-ecr-config` defines the runtime configuration for AWS ECR logins. | -| aws-login-credentials | Secret | `aws-login-credentials` defines the access accounts and credentials to log in to the AWS ECR service. Note that these credentials may be different than the `aws-s3-credentials` | +| Resource | Kind | Description | +| ------------------- | --------- | --------------------------------------------------------------------------------------------------------------------------------------------- | +| aws-ecr-config | ConfigMap | Defines the runtime configuration for AWS ECR logins. | +| aws-ecr-credentials | Secret | Defines the access accounts and credentials to log in to the AWS ECR service. Note that these may be different than the `aws-s3-credentials`. | ## SSL Termination