-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test - delete an engine with a running build #127
Comments
The abbreviated error message showing the need:
|
may be related to #121 - about things happening that aren't quite complete. |
Or, we disallow deletion on an engine if there is an active build and tell the user to cancel the build first. |
This sounds like a bug. It should cancel the build automatically. |
So, will we also need a "deleting" state? Or is that superfluous? Once it is deleted, there is no expectation of it existing. Yet, the cancelling and deleting may take 20 seconds to fully push through the whole system. How should this be handled? |
We don't need a "deleting" state for builds. The "canceling" state should suffice. Right now, the delete request blocks until the current build has stopped and the engine was successfully deleted. I don't love this, but the alternative is to make the delete operation asynchronous, which means that we don't have a good way to report a failed delete operation back the calling application. |
If that is the current behavior - then let's make sure that it is tested fully and I will be ok. We should be able to do this with unit tests at the Machine level. @ddaspit do you agree? |
Yeah, sounds good. |
To implement: Nmt and Smt test - delete the engine while the engine is building. Unit tests in Machine. May end up just being implemented in sillsdev/machine#101. |
It gave a few errors - it should close down gracefully.
Specifically, if a new engine is created and is in the process of being built (pending or active), the jobs should cancel before it is all deleted. There may also be a need for a state "deleting" ... maybe...
The text was updated successfully, but these errors were encountered: