Skip to content

Commit 8fd16d2

Browse files
committed
Remove id from paragraph poetry styles, sync styles with backend
1 parent b795565 commit 8fd16d2

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

src/SIL.XForge.Scripture/ClientApp/src/app/shared/text/text-view-model.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ const PARA_STYLES: Set<string> = new Set<string>([
4444
'lf',
4545
'lim',
4646

47-
// Book
48-
'id'
47+
// Should not contain verse text, but sometimes do
48+
'b'
4949
]);
5050

5151
function canParaContainVerseText(style: string): boolean {

src/SIL.XForge.Scripture/ClientApp/src/app/shared/text/text.component.spec.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -341,8 +341,9 @@ describe('TextComponent', () => {
341341
env.fixture.detectChanges();
342342
expect(env.isSegmentHighlighted(1, '1')).toBe(true);
343343
expect(env.isSegmentHighlighted(1, '1/q_1')).toBe(true);
344-
expect(env.isSegmentHighlighted(1, '1/q_2')).toBe(true);
344+
expect(env.isSegmentHighlighted(1, '1/b_2')).toBe(true);
345345
expect(env.isSegmentHighlighted(1, '1/q_3')).toBe(true);
346+
expect(env.isSegmentHighlighted(1, '1/q_4')).toBe(true);
346347

347348
TestEnvironment.waitForPresenceTimer();
348349
}));
@@ -414,8 +415,8 @@ describe('TextComponent', () => {
414415
env.waitForEditor();
415416

416417
const verseSegments: string[] = env.component.getVerseSegments(new VerseRef('LUK 1:1'));
417-
expect(verseSegments).toEqual(['verse_1_1', 'verse_1_1/q_1', 'verse_1_1/q_2', 'verse_1_1/q_3']);
418-
const segmentText = env.component.getSegmentText('verse_1_1/q_2');
418+
expect(verseSegments).toEqual(['verse_1_1', 'verse_1_1/q_1', 'verse_1_1/b_2', 'verse_1_1/q_3', 'verse_1_1/q_4']);
419+
const segmentText = env.component.getSegmentText('verse_1_1/q_3');
419420
expect(segmentText).toEqual('Poetry third line');
420421
}));
421422

src/SIL.XForge.Scripture/Services/DeltaUsxMapper.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,6 @@ private static XmlSchemaSet CreateSchemaSet()
6363
"lim",
6464
// Should not contain verse text, but sometimes do
6565
"b",
66-
// Book
67-
"id",
6866
];
6967

7068
private class ParseState

0 commit comments

Comments
 (0)