SF-3610 Adding a latest draft check to formatting button

Before, we we only checked if the latest draft contained that book, so older drafts still had the formatting button enabled. Now, we confirm the button is only enabled when the latest revision is selected.

Author: josephmyers

src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor-draft/editor-draft.component.html

@@ -45,10 +45,10 @@
         <div class="apply-draft-button-container">
           @if (showDraftOptionsButton$ | async) {
             <span
-              [matTooltip]="t(doesLatestHaveDraft ? 'format_draft_can' : 'format_draft_cannot')"
-              [style.cursor]="doesLatestHaveDraft ? 'pointer' : 'not-allowed'"
+              [matTooltip]="t(canConfigureFormatting ? 'format_draft_can' : 'format_draft_cannot')"
+              [style.cursor]="canConfigureFormatting ? 'pointer' : 'not-allowed'"
             >
-              <button mat-button (click)="navigateToFormatting()" [disabled]="!doesLatestHaveDraft">
+              <button mat-button (click)="navigateToFormatting()" [disabled]="!canConfigureFormatting">
                 <mat-icon>build</mat-icon>
                 <transloco key="editor_draft_tab.format_draft"></transloco>
               </button>

src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor-draft/editor-draft.component.spec.ts

@@ -558,6 +558,89 @@ describe('EditorDraftComponent', () => {
     }));
   });
 
+  describe('canConfigureFormatting', () => {
+    beforeEach(() => {
+      when(mockFeatureFlagService.newDraftHistory).thenReturn(createTestFeatureFlag(true));
+      when(mockDraftGenerationService.getGeneratedDraftHistory(anything(), anything(), anything())).thenReturn(
+        of(draftHistory)
+      );
+      spyOn<any>(component, 'getTargetOps').and.returnValue(of(targetDelta.ops));
+      when(mockDraftHandlingService.getDraft(anything(), anything())).thenReturn(of(draftDelta.ops!));
+      when(mockDraftHandlingService.draftDataToOps(anything(), anything())).thenReturn(draftDelta.ops!);
+    });
+
+    it('should be true when latest build has draft and selected revision is latest', fakeAsync(() => {
+      const testProjectDoc: SFProjectProfileDoc = {
+        data: createTestProjectProfile({
+          texts: [
+            {
+              bookNum: 1,
+              chapters: [{ number: 1, permissions: { user01: SFProjectRole.ParatextAdministrator }, hasDraft: true }]
+            }
+          ]
+        })
+      } as SFProjectProfileDoc;
+      when(mockDraftGenerationService.draftExists(anything(), anything(), anything())).thenReturn(of(true));
+      when(mockActivatedProjectService.changes$).thenReturn(of(testProjectDoc));
+
+      fixture.detectChanges();
+      tick(EDITOR_READY_TIMEOUT);
+
+      expect(component.isSelectedDraftLatest).toBe(true);
+      expect(component.canConfigureFormatting).toBe(true);
+      flush();
+    }));
+
+    it('should be false when selected revision is not the latest', fakeAsync(() => {
+      const testProjectDoc: SFProjectProfileDoc = {
+        data: createTestProjectProfile({
+          texts: [
+            {
+              bookNum: 1,
+              chapters: [{ number: 1, permissions: { user01: SFProjectRole.ParatextAdministrator }, hasDraft: true }]
+            }
+          ]
+        })
+      } as SFProjectProfileDoc;
+      when(mockDraftGenerationService.draftExists(anything(), anything(), anything())).thenReturn(of(true));
+      when(mockActivatedProjectService.changes$).thenReturn(of(testProjectDoc));
+
+      fixture.detectChanges();
+      tick(EDITOR_READY_TIMEOUT);
+      expect(component.canConfigureFormatting).toBe(true);
+
+      // Select earlier revision
+      component.onSelectionChanged({ value: draftHistory[1] } as MatSelectChange);
+      fixture.detectChanges();
+      tick(EDITOR_READY_TIMEOUT);
+
+      expect(component.isSelectedDraftLatest).toBe(false);
+      expect(component.canConfigureFormatting).toBe(false);
+      flush();
+    }));
+
+    it('should be false when latest build does not have a draft', fakeAsync(() => {
+      const testProjectDoc: SFProjectProfileDoc = {
+        data: createTestProjectProfile({
+          texts: [
+            {
+              bookNum: 1,
+              chapters: [{ number: 1, permissions: { user01: SFProjectRole.ParatextAdministrator }, hasDraft: false }]
+            }
+          ]
+        })
+      } as SFProjectProfileDoc;
+      when(mockDraftGenerationService.draftExists(anything(), anything(), anything())).thenReturn(of(false));
+      when(mockActivatedProjectService.changes$).thenReturn(of(testProjectDoc));
+
+      fixture.detectChanges();
+      tick(EDITOR_READY_TIMEOUT);
+      expect(component.isSelectedDraftLatest).toBe(true);
+      expect(component.canConfigureFormatting).toBe(false);
+      flush();
+    }));
+  });
+
   describe('getLocalizedBookChapter', () => {
     it('should return an empty string if bookNum or chapter is undefined', () => {
       component.bookNum = undefined;

src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor-draft/editor-draft.component.ts

@@ -120,13 +120,21 @@ export class EditorDraftComponent implements AfterViewInit, OnChanges {
     return this.draftHandlingService.canApplyDraft(this.targetProject, this.bookNum, this.chapter, this.draftDelta.ops);
   }
 
+  get canConfigureFormatting(): boolean {
+    return this.doesLatestHaveDraft && this.isSelectedDraftLatest;
+  }
+
   get doesLatestHaveDraft(): boolean {
     return (
       this.targetProject?.texts.find(t => t.bookNum === this.bookNum)?.chapters.find(c => c.number === this.chapter)
         ?.hasDraft ?? false
     );
   }
 
+  get isSelectedDraftLatest(): boolean {
+    return this.selectedRevision?.timestamp === this._draftRevisions[0].timestamp;
+  }
+
   set draftRevisions(value: Revision[]) {
     this._draftRevisions = value;
   }