Formatting button gets removed instead of disabled

Author: josephmyers

src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor-draft/editor-draft.component.html

@@ -43,12 +43,9 @@
           </mat-form-field>
         }
         <div class="apply-draft-button-container">
-          @if (showDraftOptionsButton$ | async) {
-            <span
-              [matTooltip]="t(canConfigureFormatting ? 'format_draft_can' : 'format_draft_cannot')"
-              [style.cursor]="canConfigureFormatting ? 'pointer' : 'not-allowed'"
-            >
-              <button mat-button (click)="navigateToFormatting()" [disabled]="!canConfigureFormatting">
+          @if ((isFormattingSupportedForLatest$ | async) && canConfigureFormatting) {
+            <span [matTooltip]="t('format_draft_tooltip')">
+              <button mat-button (click)="navigateToFormatting()">
                 <mat-icon>build</mat-icon>
                 <transloco key="editor_draft_tab.format_draft"></transloco>
               </button>

src/SIL.XForge.Scripture/ClientApp/src/app/translate/editor/editor-draft/editor-draft.component.ts

@@ -115,7 +115,7 @@ export class EditorDraftComponent implements AfterViewInit, OnChanges {
     this.onlineStatusService.onlineStatus$
   ]).pipe(map(([isLoading, isOnline]) => isLoading || !isOnline));
 
-  showDraftOptionsButton$: Observable<boolean> = this.activatedProjectService.projectId$.pipe(
+  isFormattingSupportedForLatest$: Observable<boolean> = this.activatedProjectService.projectId$.pipe(
     filterNullish(),
     switchMap(projectId => this.draftGenerationService.getLastCompletedBuild(projectId)),
     map(build => this.draftOptionsService.areFormattingOptionsSupportedForBuild(build))

src/SIL.XForge.Scripture/ClientApp/src/assets/i18n/non_checking_en.json

@@ -410,8 +410,7 @@
     "draft_legacy_warning": "We have updated our drafting functionality. You can take advantage of this by [link:generateDraftUrl]generating a new draft[/link].",
     "error_applying_draft": "Failed to add the draft to the project. Try again later.",
     "format_draft": "Formatting options",
-    "format_draft_can": "Customize formatting options for the draft",
-    "format_draft_cannot": "You can only change formatting for books from the latest draft",
+    "format_draft_tooltip": "Customize formatting options for the draft",
     "no_draft_notice": "{{ bookChapterName }} has no draft.",
     "offline_notice": "Generated drafts are not available offline.",
     "overwrite": "Adding the draft will overwrite the current chapter. Are you sure you want to continue?",