Skip to content

Conversation

@RaymondLuong3
Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 commented Oct 30, 2025

The problem occurs in the draft history entry because we do not have a permission check if the user can access the training or translation source projects.


This change is Reviewable

@RaymondLuong3 RaymondLuong3 added the will require testing PR should not be merged until testers confirm testing is complete label Oct 30, 2025
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.92%. Comparing base (a53b8f0) to head (77c11e5).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...aft-history-entry/draft-history-entry.component.ts 71.42% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3550   +/-   ##
=======================================
  Coverage   82.91%   82.92%           
=======================================
  Files         605      605           
  Lines       36894    36898    +4     
  Branches     6043     6026   -17     
=======================================
+ Hits        30592    30596    +4     
- Misses       5376     5389   +13     
+ Partials      926      913   -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RaymondLuong3 RaymondLuong3 force-pushed the fix/sf-3615-error-permissions branch from b62c1e3 to c1028ca Compare November 3, 2025 20:44
@pmachapman pmachapman self-requested a review November 4, 2025 00:19
@pmachapman pmachapman self-assigned this Nov 4, 2025
Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman)

@pmachapman pmachapman added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Nov 4, 2025
@RaymondLuong3 RaymondLuong3 force-pushed the fix/sf-3615-error-permissions branch from c1028ca to 77c11e5 Compare November 5, 2025 16:28
@RaymondLuong3 RaymondLuong3 merged commit 13bacab into master Nov 5, 2025
23 checks passed
@RaymondLuong3 RaymondLuong3 deleted the fix/sf-3615-error-permissions branch November 5, 2025 16:43
@pmachapman pmachapman added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants