Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBBoolean are actually int under the hood #166

Open
lekoala opened this issue Apr 26, 2024 · 1 comment
Open

DBBoolean are actually int under the hood #166

lekoala opened this issue Apr 26, 2024 · 1 comment

Comments

@lekoala
Copy link
Contributor

lekoala commented Apr 26, 2024

I would suggest using this as the default

      SilverStripe\ORM\FieldType\DBBoolean: bool|int

Because internally DBBoolean is a tinyint with 0|1 value, but accepting true/false as well
@Firesphere
Copy link
Member

Yeah, might be a good idea.
Just wondering, don't want to break compatibility with older versions. Haven't had a close look or anything, so I might be a bit overly cautious.

@lekoala lekoala mentioned this issue Aug 13, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lekoala @Firesphere