Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Include apache/nginx/FPM error logs in the aggregation #16

Open
robbieaverill opened this issue Jan 23, 2017 · 5 comments
Open

Comments

@robbieaverill
Copy link
Contributor

An idea that surfaced on Slack recently - to include handling for apache/nginx/PHP/FPM error logs in this module.

Presumably they wouldn't be LogEntry instances in the database, and would not be able to be deleted, but should be able to be viewed in the grid, and in detail.

@Firesphere
Copy link
Member

I would rather use a log-parser to parse the actual logs, than putting these into the database. Although a DB served log entry is faster, it serves no purpose to re-store things and pollute the database with access entries.

Parsing the logs is easy enough and the speed difference is minimal. After all, it's a CMS thing, not something that affects the frontend user!

@robbieaverill
Copy link
Contributor Author

Yeah @Firesphere - I don't see much point in parsing system logs and saving them as LogEntry records in this module - best to merge into the grid field as they're read from file

@Firesphere
Copy link
Member

I would thing, only using warning+ to show up and an option in the config to set the logging level and parsing.

https://github.com/kassner/log-parser looks promising (although that's a quick look, not in-depth)

@robbieaverill
Copy link
Contributor Author

https://github.com/kassner/log-parser looks promising (although that's a quick look, not in-depth)

Would tie nicely into #13

@Firesphere
Copy link
Member

Good spot! Also, you're clearly more awake than I am :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants