Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review access model and core core committer access #221

Open
maxime-rainville opened this issue Apr 11, 2024 · 0 comments
Open

Review access model and core core committer access #221

maxime-rainville opened this issue Apr 11, 2024 · 0 comments

Comments

@maxime-rainville
Copy link
Contributor

maxime-rainville commented Apr 11, 2024

There's about a dozen core committers to the Silverstripe CMS project. They all have owner access on the silverstripe GitHub org. This is expose us to a level of risk since if anyone of those people got their account stolen or went rogue on us, they could do a lot of damage.

In practice core committers, don't need this level of access to do their day-to-day work.

We're also keen to implement branch protection to disallow direct push and manual tagging. With the introduction of automated merge ups and tagging, the only people needing this level of access are people debugging merges up or doing releases.

User story

As the Silverstripe CMS product owner, I want to restrain the privileges to those that actually needed by contributers to perform their function to minimise the risk of illegitimate access.

Acceptance criteria

  • Core Committer doc is updated to clarify the level of access core committer have. Doc should say
    • All core committer have write and merge access on all supported repos.
    • A limited number of core committer have ownership rights on the GitHub organisation.
    • At least two Silverstripe staff members and two core committers outside Silverstripe have ownership access have ownership level access.
      • Ideally, at least one person living outside New Zealand has ownership access.
  • A @silverstripe/core-team is updated to have an appropriate description and permissions.
  • Members who will assume ownership role are agreed upon and access is updated accordingly.

Note

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant