New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bypass permissions still required to merge a pull-request after 2 approvals #258

Closed

emteknetnz opened this issue May 30, 2024 · 1 comment

Labels

Member

emteknetnz commented May 30, 2024 •

edited

Loading

After getting two approvals on a PR, bypass permissions were still required to merge this PR

The branch protection rulesets were added on #198

Clicking on "View rules" and "Silverstripe CMS branch ruleset"

I suspect that the issue is "Restrict updates" since we're updating an existing branch

When resolving get 2x developers to try approving a dummy PR on a test repo with the branch ruleset applied

Note this may be resolved after merging this

emteknetnz added the type/other label

Member

GuySartorelli commented Aug 14, 2024

That rule got reverted and won't be reinstated. See #260

GuySartorelli closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment