This repository has been archived by the owner on Sep 3, 2021. It is now read-only.
Update composer.json for the major branch 2 #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Cheddam
approved these changes
Nov 13, 2019
There was a problem hiding this comment.
Outstanding failures, per the build of this commit on the creative-commoners fork:
- A fluent test failure, cause is not immediately obvious
- Two framework test failures, related to a recent change in behaviour of the assets module (alt attribute is now always present, and defaults to being empty rather than the title of the image). Simple to fix.
Neither of these indicate an issue with kitchen-sink itself, so we'll proceed with merging this PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gonna be green when cwp-recipe-core, cwp-recipe-cms, recipe-content-blocks and symbiote/silverstripe-multivaluefield get merged.
Part of #46