Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintainer docs say peer reviewers can merge PRs, but that's no longer feasible for security reasons #552

Closed
3 tasks done
GuySartorelli opened this issue Aug 14, 2024 · 1 comment

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Aug 14, 2024

https://docs.silverstripe.org/en/5/project_governance/maintainer_guidelines/ says community peer reviewers will have the rights to merge pull requests.

Unfortunately for security reasons (see silverstripe/.github#260) that's not feasible.

Update the docs to reflect that core committers and CMS Squad members will need to merge PRs after they've been approved.

Acceptance Criteria

  • Docs are updated
  • The peer reviewers group in Silverstripe org permissions are updated if necessary
  • The project board is updated if necessary

PRs

@GuySartorelli
Copy link
Member Author

Updated the project board so it has a "ready to merge" column instead of a "needs second approval" column.

@GuySartorelli GuySartorelli removed their assignment Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants