Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of unnecessary count queries #194

Open
ScopeyNZ opened this issue Feb 11, 2019 · 0 comments
Open

Reduce number of unnecessary count queries #194

ScopeyNZ opened this issue Feb 11, 2019 · 0 comments

Comments

@ScopeyNZ
Copy link
Contributor

Recently #173 added count queries when using the SQL endpoint so that the record count could be fetched to correctly display the pagination. The record count changes when filters are updated but not when page numbers are changed or sorting is applied but we still get an additional count query.

We should not query for a count when sorting or changing page numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants