-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consolidate JSON saving form fields with a base class #65
Comments
I don't think it makes sense to do this until #25 is completed, since |
Similarly to the other issue, do we still want to do this? I'm happy to close it |
I think it's not that important on this repo. It's a good idea for |
I think it's not necessary now, but I don't think it's worth closing either (unless as @ScopeyNZ says, it's moved to |
As per point 1 in #57
@robbieaverill points out
@ScopeyNZ follows up
@NightJar continues
In summary
Create a form field type that will save JSON blobs to the database. Then continue to replace
ResourceLocatorField
,ResultConditionsField
, andPresentedOptionsField
(in an upcoming PR) with this base field, setting the react component property to use the relevant view.The text was updated successfully, but these errors were encountered: