Skip to content

Commit

Permalink
MNT Remove TODO comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Sabina Talipova committed Oct 16, 2023
1 parent 2a0ba78 commit d84a125
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 6 deletions.
2 changes: 0 additions & 2 deletions client/src/components/ElementActions/SaveAction.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,6 @@ const SaveAction = (MenuComponent) => (props) => {
// Update the Apollo query cache with the new form data
const { apolloClient } = window.ss;

// @todo optimistically update the data for the current element instead of
// rerunning the whole query
apolloClient.queryManager.reFetchObservableQueries();
reinitialiseForm(formData);

Expand Down
1 change: 0 additions & 1 deletion client/src/components/ElementEditor/AddElementPopover.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ class AddElementPopover extends Component {
} = this.props;

event.preventDefault();
// TODO This should probably use the GraphQL element type name (element.__typeName)
handleAddElementToArea(elementType.class, insertAfterElement).then(
() => {
const preview = window.jQuery('.cms-preview');
Expand Down
1 change: 0 additions & 1 deletion client/src/components/ElementEditor/ElementList.js
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ class ElementList extends Component {
}

ElementList.propTypes = {
// @todo support either ElementList or Element children in an array (or both)
blocks: PropTypes.arrayOf(elementType),
elementTypes: PropTypes.arrayOf(elementTypeType).isRequired,
allowedElementTypes: PropTypes.arrayOf(elementTypeType).isRequired,
Expand Down
2 changes: 0 additions & 2 deletions src/Forms/ElementalAreaField.php
Original file line number Diff line number Diff line change
Expand Up @@ -162,11 +162,9 @@ protected function getReadOnlyBlockReducer()
'ElementType' => $element->getType(),
'ElementIcon' => $element->config()->get('icon'),
'ElementTitle' => $element->Title,
// @todo: Change this to block history permalink when that functionality becomes available.
'ElementEditLink' => Controller::join_links(
// Always get the edit link for the block directly, not the in-line edit form if supported
$element->CMSEditLink(true),
// @todo make this auto-permalinking work somehow
'#Root_History'
),
],
Expand Down

0 comments on commit d84a125

Please sign in to comment.