Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form submission doesn't go through Form::saveInto() #1268

Closed
1 task done
GuySartorelli opened this issue Nov 6, 2024 · 0 comments
Closed
1 task done

Form submission doesn't go through Form::saveInto() #1268

GuySartorelli opened this issue Nov 6, 2024 · 0 comments
Assignees

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Nov 6, 2024

#1265 highlighted that the data submitted through the elemental area form doesn't get saved into elements using the standard Form::saveInto(). Instead, similar (but less complex) logic is re-implemented inside BaseElement::updateFromFormData().

We should rely on the standard form submission flow as much as possible, which means removing BaseElement::updateFromFormData() in favour of Form::saveInto()

Acceptance Criteria

  • Form submissions for elemental blocks get saved into elements using Form::saveInto() instead of custom logic

CMS 5 PRs

After merging, reassign to Guy to rebase the CMS 6 PR.

CMS 6 PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants