Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Individual Save & Publish #470

Open
NightJar opened this issue Oct 26, 2018 · 1 comment
Open

Improve Individual Save & Publish #470

NightJar opened this issue Oct 26, 2018 · 1 comment

Comments

@NightJar
Copy link
Contributor

Following on from #312 , there are several performance improvements that could be made to the process which is currently launching 4 requests to publish a page, and assumes that a save is necessary prior to publishing too frequently (that is, often deems it necessary when it is not).

The first issue can hopefully be addressed by @ScopeyNZ 's work in #457 - by knowing what type of element we're trying to save, we can correctly supply the fields required to be saved with the GraphQL query.

The second issue may be able to be resolved by an update to react-form, as it seems isDirty isn't quite doing as it seems it is intended (details at #312 (comment)). Otherwise it seems a custom reducer to evaluate the form state in comparing values to initial would be the answer - although less desirable to using what the library provides us.

@robbieaverill
Copy link
Contributor

Note from #517 - check when we do this that "save and publish" as well as "save" actions both take the model's validation rules into account before saving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants