Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Remove TODO comments #1112

Merged
merged 1 commit into from
Oct 25, 2023
Merged

MNT Remove TODO comments #1112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions client/src/components/ElementActions/SaveAction.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,6 @@ const SaveAction = (MenuComponent) => (props) => {
// Update the Apollo query cache with the new form data
const { apolloClient } = window.ss;

// @todo optimistically update the data for the current element instead of
// rerunning the whole query
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open ticket: #1111

apolloClient.queryManager.reFetchObservableQueries();
reinitialiseForm(formData);

Expand Down
1 change: 0 additions & 1 deletion client/src/components/ElementEditor/AddElementPopover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ class AddElementPopover extends Component {
} = this.props;

event.preventDefault();
// TODO This should probably use the GraphQL element type name (element.__typeName)
handleAddElementToArea(elementType.class, insertAfterElement).then(
() => {
const preview = window.jQuery('.cms-preview');
Expand Down
1 change: 0 additions & 1 deletion client/src/components/ElementEditor/ElementList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ class ElementList extends Component {
}

ElementList.propTypes = {
// @todo support either ElementList or Element children in an array (or both)
blocks: PropTypes.arrayOf(elementType),
elementTypes: PropTypes.arrayOf(elementTypeType).isRequired,
allowedElementTypes: PropTypes.arrayOf(elementTypeType).isRequired,
Expand Down
2 changes: 0 additions & 2 deletions src/Forms/ElementalAreaField.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,11 +162,9 @@ protected function getReadOnlyBlockReducer()
'ElementType' => $element->getType(),
'ElementIcon' => $element->config()->get('icon'),
'ElementTitle' => $element->Title,
// @todo: Change this to block history permalink when that functionality becomes available.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it have been fixed.

'ElementEditLink' => Controller::join_links(
// Always get the edit link for the block directly, not the in-line edit form if supported
$element->CMSEditLink(true),
// @todo make this auto-permalinking work somehow
'#Root_History'
),
],
Expand Down