Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Skip validation when creating a new elemental block #1172

Merged
merged 1 commit into from
Apr 19, 2024
Merged

ENH Skip validation when creating a new elemental block #1172

merged 1 commit into from
Apr 19, 2024

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Apr 18, 2024 •
edited
Loading

@GuySartorelli GuySartorelli mentioned this pull request Apr 18, 2024
Closed
2 tasks
@michalkleiner
Copy link
Contributor

I know this targets 6 but should composer.json also be updated to explicitly require silverstripe/framework: ^6? Or is that implied from the module version and they are in tied together through major versions?

@GuySartorelli
Copy link
Member Author

The constraint for the 6 branch of this module already requires framework ^6:

silverstripe-elemental/composer.json

Line 22 in 1512b17

"silverstripe/framework": "^6",

emteknetnz
emteknetnz approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've merged the dependent framework PR and am rerunning CI. Merge on green.

@GuySartorelli GuySartorelli force-pushed the pulls/6/skip-validation-on-new-block branch from 50421f2 to 68ae9b7 Compare April 18, 2024 23:34
@GuySartorelli
Copy link
Member Author

I had missed some things, fixed now.

@GuySartorelli GuySartorelli force-pushed the pulls/6/skip-validation-on-new-block branch 2 times, most recently from db85d68 to e59c5ae Compare April 18, 2024 23:36
@GuySartorelli
Copy link
Member Author

Not sure why CI isn't running against this... I tried force pushing again and it didn't trigger it. Will wait a bit and see if GitHub is just congested.

@GuySartorelli GuySartorelli force-pushed the pulls/6/skip-validation-on-new-block branch from e59c5ae to 8f4563b Compare April 19, 2024 00:28
@emteknetnz emteknetnz merged commit 5d343dc into silverstripe:6 Apr 19, 2024
13 checks passed
@emteknetnz emteknetnz deleted the pulls/6/skip-validation-on-new-block branch April 19, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuySartorelli @michalkleiner @emteknetnz