Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ReflectionClass::setStaticPropertyValue() to set cliOverride #11563

Open
1 task
emteknetnz opened this issue Jan 16, 2025 · 0 comments
Open
1 task

Use ReflectionClass::setStaticPropertyValue() to set cliOverride #11563

emteknetnz opened this issue Jan 16, 2025 · 0 comments
Labels
affects/v6 type/other

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Jan 16, 2025 •
edited
Loading

Recently a PR was merged that used deprecated syntax where calling ReflectionProperty()::setValue() with two argument causes a PHP deprecation notice as on 8.3.0

Instead we should use ReflectionClass::setStaticProperty()

PRs

  • kitchen-sink code base is updated to use ReflectionClass::setStaticProperty() where appropriate
@emteknetnz emteknetnz transferred this issue from silverstripe/.github Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v6 type/other
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emteknetnz