When a new Member
record was created in the cms it was possible to set a blank password. If an attacker knows the email address of the user with the blank password then they can attempt to log in using an empty password. The default member authenticator, login form and basic auth all require a non-empty password, however if a custom authentication method is used it may allow a successful login with the empty password. Starting with this release, blank passwords are no no longer allowed when members are created in the CMS. Programatically created Member
records, such as those used in unit tests, still allow blank passwords. You may have some Member
records in your system already which have empty passwords. To detect these, you can loop over all Member
records with Member::get()
and pass each record into the below method. It might be sensible to create a BuildTask
for this purpose.
private function memberHasBlankPassword(Member $member): bool
{
// skip default admin as this is created programatically
if ($member->isDefaultAdmin()) {
return false;
}
// return true if a blank password is valid for this member
$authenticator = new MemberAuthenticator();
return $authenticator->checkPassword($member, '')->isValid();
}
Once you have identified the records with empty passwords, it's up to you how to handle this. The most sensible way to resolve this is probably to generate a new secure password for each of these members, mark it as immediately expired, and email each affected member (assuming they have a valid email address in the system).
Reported by: Sabina Talipova from Silverstripe and Christian Bünte
When a new
Member
record was created in the cms it was possible to set a blank password. If an attacker knows the email address of the user with the blank password then they can attempt to log in using an empty password. The default member authenticator, login form and basic auth all require a non-empty password, however if a custom authentication method is used it may allow a successful login with the empty password. Starting with this release, blank passwords are no no longer allowed when members are created in the CMS. Programatically createdMember
records, such as those used in unit tests, still allow blank passwords. You may have someMember
records in your system already which have empty passwords. To detect these, you can loop over allMember
records withMember::get()
and pass each record into the below method. It might be sensible to create aBuildTask
for this purpose.Once you have identified the records with empty passwords, it's up to you how to handle this. The most sensible way to resolve this is probably to generate a new secure password for each of these members, mark it as immediately expired, and email each affected member (assuming they have a valid email address in the system).
Reported by: Sabina Talipova from Silverstripe and Christian Bünte