Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doesn't work with latest userforms version #32

Open
guyvanbael opened this issue Oct 22, 2015 · 17 comments
Open

doesn't work with latest userforms version #32

guyvanbael opened this issue Oct 22, 2015 · 17 comments

Comments

@guyvanbael
Copy link

When i updated to the latest userforms module, filling in the mathspamprotection field always result in "this field is required". Form can't be submitted anymore.

@guyvanbael guyvanbael changed the title field type is changed when using latest userforms version doesn't work with latest userforms version Oct 26, 2015
@Taitava
Copy link
Contributor

Taitava commented Nov 30, 2015

I can confirm this. I'll try to see what's wrong and will get back if I find anything. In the mean time, if anybody has any clue about this, please tell :). I can't promise any solution yet.

@tractorcow
Copy link
Contributor

Is it a server side or client side validation which is blocking submission?

@Taitava
Copy link
Contributor

Taitava commented Nov 30, 2015

@tractorcow It's server side. I have real time validation disabled.

@tractorcow
Copy link
Contributor

I remember fixing userforms a while back to work with the spam protector; I'll check if the code still works. ;)

You are using the EditableSpamProtector field, right?

@guyvanbael
Copy link
Author

yes, i am.

@Taitava
Copy link
Contributor

Taitava commented Dec 1, 2015

Me too.

@tazzydemon
Copy link

The way validation is handled appears to have changed enormously on Userforms 3.x and as far as I can tell has broken all the standard spamprotection modules including mine which was an upgrade of the old honeypot. I have asked elsewhere for the api instructions or description for how this has changed?

@guyvanbael
Copy link
Author

Thanks for looking into it. Meanwhile i'm using the invisiblespamprotection module, but the mathspamprotection always did a great job!

@tazzydemon
Copy link

Are you saying that invisiblespamprotection works for you in Userforms 3.x? It doesn't for me

@guyvanbael
Copy link
Author

Yes it does, but it isn't half as effective as mathspamprotection

@tazzydemon
Copy link

I cant find any evidence that it works with userforms 3. I can fill in the honeypot on any of the various versions including mine and the form does not get returned but submitted. Curious

@tazzydemon
Copy link

The problem was my selected version of silverstripe-spamprotection which has to be 2.0.2+ (or master)
There was a key commit made here:
silverstripe/silverstripe-spamprotection@da87f71

@guyvanbael
Copy link
Author

So did you get mathspamprotection working again? These are my entries in my composer file, but it doesn't seem to work.
"silverstripe/spamprotection": "",
"silverstripe/userforms": "dev-master",
"silverstripe/mathspamprotection":"
",

@tazzydemon
Copy link

You missed this line in composer.json
"silverstripe/spamprotection": "~2.0.2",

You also need a spamprotection.yml in your _config directory with this in it:

---
name: spamprotection
---
FormSpamProtectionExtension:
#  default_spam_protector:
  default_spam_protector:  MathSpamProtector

@tazzydemon
Copy link

By the way I have found the problem and will post an issue fix

@Taitava
Copy link
Contributor

Taitava commented Dec 8, 2015

@tazzydemon Hi, have you made any progress with the fix? Or can you provide further information about the problem? Thanks a lot! :)

@tazzydemon
Copy link

Because I'm not using this module I didn't fork and pull request like I did with silverstripe-spamprotection but if you check out issue 42 you will see the fix #42

wilr added a commit that referenced this issue Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants