-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for Raygun PHP SDK v2 when it is released #59
Comments
v2.0.0 was released on Jan 28, 2020 and there have been two minor releases since then. Has there been any work towards updating this module to support the v2 sdk? |
Hey @GuySartorelli no work that I'm aware of. I wouldn't say that this module is active development by any stretch. I'd say there's an opportunity to become a maintainer if you're interested? |
Good to know @brynwhyman |
I've taken a few minutes to look at what would be involved to resolve this issue. The three options I can see are (in no particular order):
@brynwhyman Let me know if you want me to go ahead with either of the first two options. We're doing a trial run with raygun on one of the sites we support at the moment and it is looking likely we'll be rolling it out on more of them over time, so I'm quite keen to get this module to support raygun SDK v2. Note that only the first two options would (potentially) allow supporting v1 and v2 of the sdk simultaneously - and option 3 updates a few more upstream dependencies as well. |
Hey @GuySartorelli, I'm personally open to following your lead on this, especially if you're also going to be the one to do the work! To your point, the third option is clearly the ideal, fingers crossed there might be some traction on that other pull request. I've also just shared this issue around internally in the hopes that someone else might be able to help with maintainership/ supporting this contribution to the module. |
Awesome, thank you! I think I'll wait a few weeks in hope the other PR has some movement - but failing that I think pulling the relevant code into this module (if there isn't too much of it) might be my preference. Much better than maintaining a whole extra forked package I think. Update: |
Finally got around to submitting a PR for this 🎉 |
Fantastic work, thank you! |
The PHP SDK is preparing for its v2 release, which includes some breaking changes (notably MindscapeHQ/raygun4php#117 re: client instantiation).
Just a placeholder for now, but when it's tagged it'd be a good idea to update this module to either allow both versions to be installed, or release a new minor version with an updated upstream dependency.
The text was updated successfully, but these errors were encountered: