Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PublicCDNAdapter::getPublicUrl does not correctly url encode file paths #57

Open
stnvh opened this issue Mar 23, 2023 · 0 comments
Open

PublicCDNAdapter::getPublicUrl does not correctly url encode file paths #57

stnvh opened this issue Mar 23, 2023 · 0 comments

Comments

@stnvh
Copy link

stnvh commented Mar 23, 2023 •
edited
Loading

PublicCDNAdapter builds it's own URLs using Controller::join_links which does not explicitly produce an S3 compatible link due to lack of path encoding. For example if $path contains a + S3 treats this as a space, causing a 404.

This differs from PublicAdapter which builds links via the S3ClientInterface instead, in which paths are already escaped before being returned.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stnvh