MNT Remove TODO comments #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabina-talipova
commented
Oct 12, 2023
| @@ -61,9 +61,6 @@ | |||
| }); | |||
|
|
|||
| $('.cms-edit-form').entwine({ | |||
| /** | |||
| * TODO: Fix with Entwine API extension. See https://github.com/silverstripe/silverstripe-subsites/pull/125 | |||
| */ | |||
There was a problem hiding this comment.
Open ticket: #541
sabina-talipova
commented
Oct 12, 2023
sabina-talipova
commented
Oct 12, 2023
| // If you're querying by ID, ignore the sub-site - this is a bit ugly... (but it was WAYYYYYYYYY worse) | ||
| // @TODO I don't think excluding if SiteTree_ImageTracking is a good idea however because of the SS 3.0 api and | ||
| // ManyManyList::removeAll() changing the from table after this function is called there isn't much of a choice | ||
|
|
There was a problem hiding this comment.
Open ticket: #542
sabina-talipova
commented
Oct 12, 2023
sabina-talipova
commented
Oct 12, 2023
| * @todo In the future, we will probably need to come up with a tigher object representing a partially | ||
| * complete controller with gaps for extra functionality. This, for example, would be a better way | ||
| * of letting Security/login put its log-in form inside a UI specified elsewhere. | ||
| * |
There was a problem hiding this comment.
Open ticket: #544
sabina-talipova
commented
Oct 12, 2023
src/Model/Subsite.php
Outdated
There was a problem hiding this comment.
Open ticket: #545
sabina-talipova
force-pushed
the
pulls/3.1/remove-todo
branch
2 times, most recently
from
b10411f to
5f6ff12
Compare
GuySartorelli
requested changes
Oct 24, 2023
sabina-talipova
force-pushed
the
pulls/3.1/remove-todo
branch
from
5f6ff12 to
fbeff6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue