Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example in readme for StringTagField shows deprecation warning #268

Closed
emteknetnz opened this issue Nov 20, 2023 · 1 comment
Closed

Example in readme for StringTagField shows deprecation warning #268

emteknetnz opened this issue Nov 20, 2023 · 1 comment

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Nov 20, 2023 •
edited
Loading

The example in the readme

$field = StringTagField::create(
    'Tags',
    'Tags',
    ['one', 'two'],
    explode(',', $this->Tags)
);

Will show the following warning if copy pasted:

[Deprecated] explode(): Passing null to parameter #2 ($string) of type string is deprecated

This is because $this->Tags starts off as null

PR
@emteknetnz emteknetnz mentioned this issue Nov 20, 2023
Merged
@GuySartorelli
Copy link
Member

PR merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emteknetnz @GuySartorelli