Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to add multiple keys or TOTP #44

Open
Firesphere opened this issue Sep 15, 2019 · 3 comments
Open

Unable to add multiple keys or TOTP #44

Firesphere opened this issue Sep 15, 2019 · 3 comments

Comments

@Firesphere
Copy link

Firesphere commented Sep 15, 2019

As a user

I would like to set up multiple different keys and/or TOTP apps

Because

I might have a work phone and home phone I want to set up together, or a personal key and a work key that I want to set up together

So that

I can log in from work and home, without having to worry about my work or home MFA method, e.g. if I forget my personal phone but do have my work phone, I do not loose the capability to log in

@ScopeyNZ
Copy link
Contributor

Yep I agree this is a good feature. You can technically share the QR code with multiple devices when you register, but it's awkward because you need to all the devices at the time of registration, and adding a new one means you have to re-register the old ones.

I've put this as a change/minor but if somebody implements beware that the implementation will probably have to change how the secret is stored in the RegisteredMethod - but this should be done in a non-breaking way. This might be as simple as something like:

$storedData = $registeredMethod->data;
if (!is_array($data)) {
    $data = [$data];
}

@Firesphere
Copy link
Author

I would put this as a impact/major. Because for example the FIDO alliance, agrees that "people can have multiple keys"

Restricting it to a single key (whichever it is, TOTP, Yubikey, etc.) is literally breaking the rule of being agnostic to the keys themselves.

@ScopeyNZ
Copy link
Contributor

ScopeyNZ commented Sep 17, 2019

I agree about impact/major for having multiple u2f keys - but not for TOTP keys. I think there's a separate issue for u2f keys on the webauthn repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants