API Stop using deprecated API #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
emteknetnz
force-pushed
the
pulls/1/stop-depr
branch
from
7e665d7 to
8c9ac57
Compare
emteknetnz
commented
Nov 3, 2022
| }; | ||
| } | ||
|
|
||
| private static function getVersionsList(DataObject $object) |
There was a problem hiding this comment.
This was copied from the deprecated Versioned::VersionsList()
This was the only non unit-test that called that method, so I kept it deprecated and just copied it to here as a private
emteknetnz
force-pushed
the
pulls/1/stop-depr
branch
from
8c9ac57 to
168698e
Compare
emteknetnz
commented
Nov 6, 2022
| @@ -12,7 +12,6 @@ | |||
| * Decorates TestSession object to update get / post requests with versioned querystring arguments. | |||
| * Session vars assigned by FunctionalTest::useDraftSite are respected here. | |||
| * | |||
| * @deprecated 2.2.0 Use ?stage=Stage|Live in your request's querystring instead | |||
There was a problem hiding this comment.
I've raised an issue to look at re-deprecating this separately from the rest of this issue - I don't want to leave this deprecated at this stage because I expect it to create too much noise
emteknetnz
commented
Nov 7, 2022
src/Versioned.php
Outdated
| @@ -2074,22 +2074,22 @@ public function stagesDiffer() | |||
| * @param string $join Deprecated, use leftJoin($table, $joinClause) instead | |||
| * @param string $having | |||
| * @return ArrayList | |||
| * @deprecated 1.12.0 Use allVersions() instead' | |||
There was a problem hiding this comment.
Deprecating this and undeprecating allVersions() because all this method does is all allVersions(). I have no idea why they were deprecated the other way around before.
emteknetnz
force-pushed
the
pulls/1/stop-depr
branch
2 times, most recently
from
29c571d to
75a2896
Compare
emteknetnz
force-pushed
the
pulls/1/stop-depr
branch
from
75a2896 to
5ce310f
Compare
sabina-talipova
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#10542