VendorExposeCommand execute is missing a return type.

[nlighteneddesign]

Module version(s) affected

2.0.3

Description

When the build is running in CI I get this error:

Fatal error: Declaration of SilverStripe\VendorPlugin\Console\VendorExposeCommand::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony\Component\Console\Command\Command::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int in /app/vendor/silverstripe/vendor-plugin/src/Console/VendorExposeCommand.php on line 36

W: PHP Fatal error:  Declaration of SilverStripe\VendorPlugin\Console\VendorExposeCommand::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony\Component\Console\Command\Command::execute(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int in /app/vendor/silverstripe/vendor-plugin/src/Console/VendorExposeCommand.php on line 36

How to reproduce

Build in platform.sh
I'm not sure why this isn't the same as running it locally.

Possible Solution

Add missing return type int

Additional Context

No response

Validations

• Check that there isn't already an issue that reports the same bug
• Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)

Related issue

• This plugin uses symfony console, but does not require it so a newer version can be included breaking build processes. recipe-plugin#46
• Add symfony 7 support to vendor-plugin and recipe-plugin .github#325

PR

• Add return type required by Symfony #83

[nlighteneddesign]

I'll create a PR soon

[emteknetnz]

Our CI is working fine for vendor-plugin - https://github.com/silverstripe/vendor-plugin/actions/runs/11432614774

CMS 6 uses symfony 7 and vendor-plugin 2, we're not seeing any issues with the method signature used in vendor-plugin - https://github.com/silverstripe/silverstripe-framework/blob/6/composer.json#L43

That CI build linked installed symfony 6.4 - is your CI doing the same or is it installing something more recent?

Based on silverstripe/recipe-plugin#46 I'm going to assume that you're installing symfony 7

[nlighteneddesign]

The ci is installing Symfony console 6, however I think the conflict is actually with composer greater than 2.6.6 according to support. I admit it is strange, cause I see symfony console 7 being installed as a prebuild step for composer dependencies, then composer installs my dependencies which include symfony console 6.

The site then won't build due to missing signatures.

[emteknetnz]

Seems like there's probably an issue with the composer dependencies in your project/ci then? As mentioned we are not seeing any issues with method signatures in the CI builds for either CMS 5 or CMS 6, both of which are using silverstripe/vendor-plugin:^2

As there doesn't appear to be an issue at this end I'll close this issue

[GuySartorelli]

See silverstripe/recipe-plugin#46 (comment) for why I think we should make this change

[GuySartorelli]

Closing as a duplicate of silverstripe/.github#325