Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return type required by Symfony #83

Closed
wants to merge 1 commit into from

Conversation

nlighteneddesign
Copy link

Description

This add a missing return type expected by Symfony.

Manual testing steps

I need this MR so I can test in my CI
I will review the rest later.

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@emteknetnz
Copy link
Member

We can't merge this as because a method signature change is a breaking change, so we'd need to release a new major version (3.0.0) in order to do this.

@emteknetnz emteknetnz closed this Oct 22, 2024
@nlighteneddesign
Copy link
Author

I'm not sure why you'd close this, whether you need a new version or not the next version of console requires the return type so this will eventually need to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants