Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow app consumers to set h5py options #80

Open
loichuder opened this issue Jul 6, 2023 · 2 comments
Open

Allow app consumers to set h5py options #80

loichuder opened this issue Jul 6, 2023 · 2 comments

Comments

@loichuder
Copy link
Member

loichuder commented Jul 6, 2023

We are using h5grove (in our fastapi project) to serving the h5 file to our frontend, just wondering is it possible to pass h5py optins like swmr=True with the endpoint? cause now the get_content_from_file and get_list_of_paths do accept the h5py options, but we can't pass in from the endpoint or the settings.

Originally posted by @Tinanuaa in #73 (comment)

@loichuder
Copy link
Member Author

Valid point.

I reckon having general settings for h5py in the app would make more sense than setting it at each request.

@Tinanuaa
Copy link

Tinanuaa commented Jul 6, 2023

I agree, I would prefer to have some general settings like swmr=True that we can set through the fastapi_utils.settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants