Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure correctly the entityId of the test IdP #52

Open
simevo opened this issue Oct 27, 2018 · 4 comments
Open

configure correctly the entityId of the test IdP #52

simevo opened this issue Oct 27, 2018 · 4 comments
Milestone
0.2

Comments

@simevo
Copy link
Owner

simevo commented Oct 27, 2018

A default value for the entityId of the test IdP is currenty hardwired here:
https://github.com/simevo/spid-wordpress/blob/master/templates/spid-button.php#L44

While this setting is OK for the usual docker-compose setup we use in development, it will not work for most people.

The sp_idp option has been envisaged to allow entering the entityId of the actual test IdP instace used. The code above should use that option.
@simevo simevo added this to the 0.1 milestone Oct 27, 2018
@michaeltieso
Copy link
Contributor

Do you mean that this should be an option that can be changed in the admin settings?

@simevo
Copy link
Owner Author

simevo commented Oct 29, 2018

Yes, we already have it !
screenshot_20181029_124858

@michaeltieso
Copy link
Contributor

I'll get this working today. In the meantime, I'll need to merge the new admin section first.

@simevo simevo modified the milestones: 0.1, 0.2 Oct 30, 2018
@simevo
Copy link
Owner Author

simevo commented Oct 30, 2018

This is mostly done, but we are blocked by #73 ; deferring to milestone 0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
2 participants
@michaeltieso @simevo