Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work behind a proxy #6

Open
saily opened this issue Jun 23, 2015 · 7 comments
Open

Does not work behind a proxy #6

saily opened this issue Jun 23, 2015 · 7 comments

Comments

@saily
Copy link

saily commented Jun 23, 2015

Because urllib does not use system proxy by default, this will not work in a proxied environment. If you start from command line and use the curl fallback, it works fine.

  1. think about using requests instead of urllib which automatically reuses proxy environment
  2. allow proxy configuration in user settings.

what do you think?

@simion
Copy link
Owner

simion commented Jun 23, 2015

Will rewrite api to use requests :)

@saily
Copy link
Author

saily commented Jun 23, 2015

I just forked the project and try to contribute some code.

@simion
Copy link
Owner

simion commented Jun 23, 2015

Awesome, I'll leave it in you then. The change should be simple. I wasn't aware of requests when i wrote the plugin, that's why it is build with urllib :)

@saily
Copy link
Author

saily commented Jun 23, 2015

the thing i'm not sure about is that requests is not a python standard lib. this will blow up the plugin and i'm not quite sure how to ship 3rd party libraries within the plugin.

@simion
Copy link
Owner

simion commented Jun 23, 2015

http://stackoverflow.com/a/15180938
You could give it a try.

@simion
Copy link
Owner

simion commented Jun 24, 2015

Any progress with including requests bundle into the plugin? :)

@saily
Copy link
Author

saily commented Jun 24, 2015

i did not event have time to follow your link :-) if you can do it earlier, i'd really appreciate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants