Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sklearn optional dependency for the tests in pyproject toml #27

Open
simon-hirsch opened this issue Sep 20, 2024 · 1 comment
Open

Make sklearn optional dependency for the tests in pyproject toml #27

simon-hirsch opened this issue Sep 20, 2024 · 1 comment
Labels
bug Something isn't working testing Features without tests

Comments

@simon-hirsch
Copy link
Owner

For running tests we need pytest and sklearn as we test against sklearns implementation of coordinate descent. We should make this explicit in the pyproject.toml.

sklearn has quite a few dependencies and we currently only have it as "soft" dependency for testing (not explicity noted in the pyproject.toml). Allowing for pipelines would be cool though.

Originally posted by @simon-hirsch in #25 (comment)
@simon-hirsch simon-hirsch added bug Something isn't working testing Features without tests labels Sep 20, 2024
@simon-hirsch
Copy link
Owner Author

Also we might want to check whether we distribute the tests with source :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working testing Features without tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simon-hirsch