lot of noice fixes

Author: Androz2091

src/ch/epfl/chacun/Board.java

@@ -344,6 +344,12 @@ public boolean couldPlaceTile(Tile tile) {
                 );
     }
 
+    public boolean couldPlaceTileAtPos(Tile tile, Pos pos) {
+        return insertionPositions().contains(pos) &&
+                Rotation.ALL.stream()
+                        .anyMatch(rotation -> canAddTile(new PlacedTile(tile, null, rotation, pos)));
+    }
+
     /**
      * Checks if the board has at least one tile, to prevent
      * unwanted operations on an empty board

src/ch/epfl/chacun/gui/BoardUI.java

@@ -91,7 +91,7 @@ public static Node create(
         ObservableValue<Set<Animal>> cancelledAnimalsO = boardO.map(Board::cancelledAnimals);
         // the fringe only exists when the next action is to place a tile
         ObservableValue<Set<Pos>> fringeTilesO = gameStateO.map(
-                state -> state.nextAction() == GameState.Action.PLACE_TILE
+                state -> (state.nextAction() == GameState.Action.PLACE_TILE && isOwnerCurrentPlayerO.getValue())
                         // important to understand
                         // we can not use boardO.getValue() here!
                         // because this map may be triggered before boardO gets updated!
@@ -148,23 +148,27 @@ public static Node create(
                     if (!isInFringeO.getValue()) return new CellData(Color.TRANSPARENT);
 
                     PlayerColor currentPlayer = gameStateO.getValue().currentPlayer();
+                    assert currentPlayer != null;
+
 
                     // if the mouse is currently on this tile (in the fringe) we display it normally
                     // if it can be placed there with its current position, and with a white veil otherwise
                     if (group.isHover()) {
                         PlacedTile willBePlacedTile = new PlacedTile(
                                 gameStateO.getValue().tileToPlace(), currentPlayer, rotationO.getValue(), pos
                         );
-                        return new CellData(willBePlacedTile,
-                                boardO.getValue().canAddTile(willBePlacedTile) ? Color.TRANSPARENT : Color.WHITE
-                        );
+                        boolean canBePlaced = boardO.getValue().canAddTile(willBePlacedTile);
+                        return new CellData(willBePlacedTile, canBePlaced ? Color.TRANSPARENT : Color.WHITE);
                     }
+
+                    boolean couldBePlaced = boardO.getValue().couldPlaceTileAtPos(gameStateO.getValue().tileToPlace(), pos);
+
                     // finally, if the tile is in the fringe but the mouse is not on it,
                     // we display it with a veil of the current player's color
-                    return new CellData(ColorMap.fillColor(currentPlayer));
+                    return new CellData(ColorMap.fillColor(currentPlayer).deriveColor(0, 1, 1, couldBePlaced ? 1 : .5));
                     // these arguments are the sensibility of the code,
                     // every time one of them changes, the code is re-executed
-                }, isInFringeO, group.hoverProperty(), rotationO, darkVeilEnabledO, placedTileO);
+                }, isInFringeO, group.hoverProperty(), rotationO, darkVeilEnabledO, placedTileO, isOwnerCurrentPlayerO);
 
                 // we bind the graphical properties of the group to the cell data's values
                 group.rotateProperty().bind(cellDataO.map(cellData -> cellData.tileRotation().degreesCW()));

src/ch/epfl/chacun/gui/Launcher.java

@@ -0,0 +1,7 @@
+package ch.epfl.chacun.gui;
+
+public class Launcher {
+    public static void main(String[] args) {
+        Main.main(args);
+    }
+}

src/ch/epfl/chacun/gui/Main.java

@@ -78,8 +78,8 @@ public void start(Stage primaryStage) {
         String gameName = "androzGame";
         String mySuperName = "Androz" + new Random().nextInt(1000);
         WSClient wsClient = new WSClient(
-            gameName,
-            mySuperName
+                gameName,
+                mySuperName
         );
 
         Parameters parameters = getParameters();
@@ -154,17 +154,17 @@ public void start(Stage primaryStage) {
             if (!isOwnerCurrentPlayerO.getValue()) return;
             GameState currentGameState = gameStateO.getValue();
             Board board = currentGameState.board();
-            int tileId = Zone.tileId(occupant.zoneId());
+            int tileId = occupant != null ? Zone.tileId(occupant.zoneId()) : -1;
             switch (currentGameState.nextAction()) {
                 case OCCUPY_TILE -> {
                     assert board.lastPlacedTile() != null;
-                    if (tileId != board.lastPlacedTile().id()) return;
+                    if (tileId != board.lastPlacedTile().id() && occupant != null) return;
                     saveStateAndDispatch(ActionEncoder.withNewOccupant(currentGameState, occupant), gameStateO, actionsO, wsClient);
                 }
                 case RETAKE_PAWN -> {
                     if (
-                            (occupant.kind() != Occupant.Kind.PAWN)
-                                    || (currentGameState.currentPlayer() != board.tileWithId(tileId).placer())
+                            occupant != null &&
+                                    (occupant.kind() != Occupant.Kind.PAWN || (currentGameState.currentPlayer() != board.tileWithId(tileId).placer()))
                     ) return;
                     saveStateAndDispatch(ActionEncoder.withOccupantRemoved(currentGameState, occupant), gameStateO, actionsO, wsClient);
                 }

src/ch/epfl/chacun/gui/PlayersUI.java

@@ -60,11 +60,10 @@ public static Node create(
         ObservableValue<List<PlayerColor>> players = gameStateO.map(GameState::players);
 
         Function<List<PlayerColor>, Boolean> addPlayersNodes = (newPlayers) -> {
+            vBox.getChildren().clear();
             System.out.println("rerender players");
             System.out.println(newPlayers.stream().map(e -> textMaker.playerName(e)).collect(Collectors.joining()));
             newPlayers
-                    .stream()
-                    .skip(vBox.getChildren().size())
                     .forEach(playerColor -> {
                         String name = textMaker.playerName(playerColor);