Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extended options passed to kwargs value #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jscotka
Copy link

@jscotka jscotka commented Mar 5, 2015

in python dict syntax like
-o '{"a":"b","c":"d"}'

It if feature for pass options to drivers to **kwargs
it allow to change default values for:
processor
memory
network
storage pool
arch
and some other

  in python dict syntax like
  -o '{"a":"b","c":"d"}'
@simon3z
Copy link
Owner

simon3z commented Mar 5, 2015

Thanks @jscotka it looks ok for now, can you please update the test help string? (build is failing now)

@simon3z
Copy link
Owner

simon3z commented Mar 7, 2015

@jscotka actually now that I remember, I wanted to implement this part passing a yaml file (instead of the python dictionary string as you did). Do you want to give it a try to implement it with yaml?

@jscotka
Copy link
Author

jscotka commented Mar 8, 2015

Hi @simon3z, yaml file or similar will be better and more extensible. I've choosed this dict, because it was very easy and straghtforward to implement it and pass params directly.

@jscotka
Copy link
Author

jscotka commented Mar 10, 2015

Hi,
I'm not familar with that building processes connected with github, it seems that there are some unittest what tests also lenght of whole help and similar. I would like to not touch these codes.
Moving to yaml syntax is possible, but for now it takes too long time to implement it, because it needs better handle that. now solution is pythonish hack :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants