Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolution settings #12

Open
rossbeazley opened this issue Aug 6, 2020 · 6 comments
Open

Resolution settings #12

rossbeazley opened this issue Aug 6, 2020 · 6 comments

Comments

@rossbeazley
Copy link

Hi,

Love this app, I've modified it to always pick the highest resolution for the selected camera. I had one that defaulted to 640x480, yuk.

Would you be interested in a PR?

I thought it might be better if there was another menu option so a user could select from the supported resolutions, would this be if interest to you?

Let me know and I'll do it.

@simonguest
Copy link
Owner

That would be great, Ross - a sub menu with available resolutions from the camera would be a useful feature.

@beazlr02
Copy link
Contributor

So a quick play around to get something working locally and i can make a list like this

Screenshot 2020-09-18 at 12 28 04

Note ive differentiated different codecs the camera supports even though its technically the same res, im thinking we should just collapse down into a single resolution set as thats maybe a normal user might want?

Do you have any preferences?

PS i use this app several times a week at work for sharing whiteboard sessions and phone demos, its great!

Screenshot 2020-09-18 at 12 32 17

@simonguest
Copy link
Owner

simonguest commented Sep 28, 2020

Thanks for looking into this, Ross. What would you think about putting the resolution menu as a submenu of the camera source. Something like:

Camera => Select Source => C922 Pro Stream Webcam => 640x480
                                                     720x480
                                                     800x600
                                                     1024x768
                                                     1600x1200 
                                                     1920x1080 ✔️

A check mark would indicate the selected resolution (with it defaulting to the highest resolution upon start). I also agree that we shouldn't show the codecs. (Also, selecting the camera name should still work as it does today.)

@beazlr02
Copy link
Contributor

sounds good to me, ill give that a go and submit a PR

@beazlr02
Copy link
Contributor

please see #14

@ajmas
Copy link

ajmas commented Jan 24, 2021

BTW would it be worth having Quick Camera default to the highest resolution supported by the selected source device? I just realised I was capturing at half the resolution the device supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants