Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous Integration #20

Open
ajmas opened this issue Jan 24, 2021 · 2 comments
Open

Continuous Integration #20

ajmas opened this issue Jan 24, 2021 · 2 comments

Comments

@ajmas
Copy link

ajmas commented Jan 24, 2021

Now that GitHub supports Continuous Integration, via GitHub workflows, it could be interesting to have this project have a CI target for this, even if the builds aren't signed.

@simonguest
Copy link
Owner

This is a great idea. The challenge I've faced (other than lack of time to look into this!) is how to include a test suite with any CI implementation. i.e. how to prove no regression for mirroring/rotating the image. I guess one way could be to mock/stub out the AVCaptureDevice, but that's likely a non-trivial piece of work.

@ajmas
Copy link
Author

ajmas commented Jan 31, 2021

While tests would be ideal, maybe simply start with validating the app build and run the code through a linter to ensure contributions respect a prescribed code style. For example, whether to require semi-colons or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants