Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract skybox with wrapping safety #36

Open
guanyilun opened this issue Feb 24, 2022 · 1 comment
Open

extract skybox with wrapping safety #36

guanyilun opened this issue Feb 24, 2022 · 1 comment

Comments

@guanyilun
Copy link
Collaborator

Extracting a skybox from a map needs to be safe when wrapping is involved.

@xzackli
Copy link
Collaborator

xzackli commented Feb 24, 2022

The most common situation involves wrapping over RA, so that can be the first thing to support. Handling the poles is slightly more involved.

The way we've chosen dimensions, RA is the first dimension and thus rings have stride=1 (good for SHTs). That means that a fast extraction should be something like

  1. identify where the RA seam is, by doing sky2pix on each RA of the x-axis
  2. generate two slices corresponding to "left of seam" and "right of seam".
  3. copy over those two pieces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants