Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enmap.submap docs are misleading #129

Open
mhasself opened this issue Apr 6, 2021 · 1 comment
Open

enmap.submap docs are misleading #129

mhasself opened this issue Apr 6, 2021 · 1 comment

Comments

@mhasself
Copy link
Member

mhasself commented Apr 6, 2021

Documentation of submap is misleading. If cdelt has negative elements (and it probably should), then the recommended positions of "ra_min" and "ra_max" will cause the wcs of the output map to have all positive cdelt (which, as readers of my ellipses will not be surprised to learn, I think it should not).

The docstring is a little more clear, using "xfrom" and "xto" instead of min and max.

To avoid confusion it might be helpful if submap had a noflip argument, like subinds does.

@msyriac
Copy link
Member

msyriac commented Apr 6, 2021

My bad; agreed that "from" and "to" is better, along with possibly adding a note on the negative cdelt convention.
I leave it to you and @amaurea re: adding noflip. I support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants