WARN! --confirm is deprecated, please use --yes instead

[simonw]

Spotted this in the output here: https://github.com/simonw/scotrail-datasette/runs/7934863951?check_suite_focus=true

[simonw]

Relevant code:

datasette-publish-vercel/datasette_publish_vercel/__init__.py

Line 289 in 57aed0f

cmd = ["vercel", "--confirm"]

[simonw]

Tested my fix for this locally and got:

Vercel CLI 27.2.0
Error! unknown or unexpected option: --yes
Error: Command '['vercel', '--yes', '--prod', '--env',

This is a bit tricky: I don't want to break this plugin for people who have an older version of Vercel installed, but I'd like people with the newer version not to get that warning.

[simonw]

This change is from https://github.com/vercel/vercel/releases/tag/vercel%4027.4.0

• [cli] Standardize on --yes instead of --confirm vercel/vercel#8330

So I could run vercel --version and check if it's equal to or higher than 27.4.0.

[simonw]

Here's my prototype fix so far:

diff --git a/datasette_publish_vercel/__init__.py b/datasette_publish_vercel/__init__.py
index 7aa18a1..ba19214 100644
--- a/datasette_publish_vercel/__init__.py
+++ b/datasette_publish_vercel/__init__.py
@@ -286,7 +286,7 @@ def _publish_vercel(
             click.echo("    vercel --prod".format(generate_dir), err=True)
         else:
             # Run the deploy with Vercel
-            cmd = ["vercel", "--confirm"]
+            cmd = ["vercel", "--yes"]
             if debug:
                 cmd.append("--debug")
             if not no_prod:
diff --git a/tests/test_publish_vercel.py b/tests/test_publish_vercel.py
index ff216a7..2eb51e2 100644
--- a/tests/test_publish_vercel.py
+++ b/tests/test_publish_vercel.py
@@ -70,7 +70,7 @@ def test_publish_vercel(mock_run, mock_which, alias):
                 mock.call(
                     [
                         "vercel",
-                        "--confirm",
+                        "--yes",
                         "--prod",
                         "--env",
                         "DATASETTE_SECRET=S",
@@ -108,7 +108,7 @@ def test_publish_vercel_public(mock_run, mock_which):
                 mock.call(
                     [
                         "vercel",
-                        "--confirm",
+                        "--yes",
                         "--prod",
                         "--public",
                         "--env",
@@ -150,7 +150,7 @@ def test_publish_vercel_token(mock_run, mock_which):
                 mock.call(
                     [
                         "vercel",
-                        "--confirm",
+                        "--yes",
                         "--prod",
                         "--token",
                         "xyz",