-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Astro plugin with partytown support #708
Comments
Happy to give you a year for free in exchange for a plugin :) |
It's a deal! :) I'll bump this issue when I have one ready. Any preferences on coding styles or any other aspects I should be aware of before getting started? |
Just use the default prettier and we're good to go! |
I'll get back to you with a link for the first version early next week. Thanks! |
Have a look and let me know what you think, please: https://github.com/ViorelMocanu/astro-simpleanalytics-plugin (it's already published on NPM here) |
Thanks! Would you mind adding it to https://github.com/simpleanalytics/astro-plugin? I added you as a collaborator. We can auto-deploy from main with something like this: https://github.com/simpleanalytics/vue-plugin/blob/main/.github/workflows/release.yml |
Done. Imported from the original repo after tweaking the
Thanks! :) |
@adriaanvanrossum any updates regarding the above? ^ |
Thanks for your patience. You did an outstanding job! Wow. I added the NPM credentials. Deploy should work now. Should we keep it consistent with our other packages and rename it to If you could make a PR at https://github.com/simpleanalytics/docs/blob/master/_docs/31_integrations/00_astro.md, that would be great. Just a simple how to use would be enough. |
Thanks for the reply! |
It would be great (and it would help promote your solution) if you could create an Astro plugin. The integration is super simple even without one, but it would probably help visibility and usage for Astro enthusiasts.
Of course, having an option to add the Light vs Full script is essential (since Astro prides itself to be as lightweight as possible).
Another required step you could take is natively integrating with Astro Partytown as an optional feature, while you're at it.
Then you could get listed as a new recipe in the Astro Integrations marketplace, Astro Integrations Guide or generic recipes section (or, ideally, everywhere).
Thank you for the wonderful product you're building!
The text was updated successfully, but these errors were encountered: